Skip to content

mudScrollManager.js: Fix scrollToBottom ignoring scroll behavior#9134

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:scroll_smooth
Jun 7, 2024
Merged

mudScrollManager.js: Fix scrollToBottom ignoring scroll behavior#9134
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:scroll_smooth

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Jun 6, 2024

Description

Fixes: #9127

How Has This Been Tested?

Visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro requested a review from henon June 6, 2024 22:53
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jun 6, 2024
@ScarletKuro ScarletKuro mentioned this pull request Jun 6, 2024
Closed
2 tasks
@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (28bc599) to head (aad59bf).
Report is 255 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9134      +/-   ##
==========================================
+ Coverage   89.82%   90.65%   +0.82%     
==========================================
  Files         412      398      -14     
  Lines       11878    12408     +530     
  Branches     2364     2412      +48     
==========================================
+ Hits        10670    11249     +579     
+ Misses        681      621      -60     
- Partials      527      538      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 9225b67 into MudBlazor:dev Jun 7, 2024
@ScarletKuro ScarletKuro deleted the scroll_smooth branch June 7, 2024 15:30
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ScrollManager.ScrollToBottomAsync does not properly respond to behavior parameter

1 participant

@ScarletKuro