MudFocusTrap: Don't hide focusable elements from accessibility tree#9095
MudFocusTrap: Don't hide focusable elements from accessibility tree#9095henon merged 1 commit intoMudBlazor:devfrom
Conversation
Reverts parts of MudBlazor#9007 > The problem is: Removing a focusable element like a link from the accessibility tree does not remove it from tab order. A screen reader user tabbing through the website will arrive at the link and hear “empty” or something similar. Please, don't do this! Going to err on the side of caution because it's easy to make accessibility worse unintentionally. https://oidaisdes.org/common-aria-mistakes.en/
danielchalmers
added
the
accessibility
github-actions
bot
added
bug
|
@igotinfected Another revision on previous changes. I don't think you should hide elements from the accessibility tree if they can be focused. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9095 +/- ##
==========================================
+ Coverage 89.82% 90.60% +0.77%
==========================================
Files 412 398 -14
Lines 11878 12382 +504
Branches 2364 2406 +42
==========================================
+ Hits 10670 11219 +549
+ Misses 681 623 -58
- Partials 527 540 +13 ☔ View full report in Codecov by Sentry. |
Not too knowledgeable about this one -- I find it odd that you can focus the focus trap itself rather than whatever is contained within it (I'm guessing the focus jumps to something more logical when you do though), though to me it does make sense not to |
|
@henon Ready |
|
Thanks Daniel |
3 participants
Description
Reverts parts of #9007
Going to err on the side of caution because it's easy to make accessibility worse unintentionally.
https://oidaisdes.org/common-aria-mistakes.en/
How Has This Been Tested?
visually
Type of Changes
Checklist
dev).