MudDataGrid: Fixed serverData + virtualization bug (#5664)#9086
Merged
henon merged 11 commits intoMudBlazor:devfrom Jun 3, 2024
Merged
MudDataGrid: Fixed serverData + virtualization bug (#5664)#9086henon merged 11 commits intoMudBlazor:devfrom
henon merged 11 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #9086 +/- ##
==========================================
+ Coverage 89.82% 90.66% +0.83%
==========================================
Files 412 398 -14
Lines 11878 12410 +532
Branches 2364 2412 +48
==========================================
+ Hits 10670 11251 +581
+ Misses 681 621 -60
- Partials 527 538 +11 ☔ View full report in Codecov by Sentry. |
This reverts commit bc5f159.
Member
|
Is this related #9084? |
ScarletKuro
reviewed
May 30, 2024
Riccorbypro
reviewed
May 31, 2024
This certainly seems like a solution fit for my use case. |
Riccorbypro
approved these changes
May 31, 2024
Riccorbypro
approved these changes
May 31, 2024
ScarletKuro
approved these changes
May 31, 2024
henon
removed
docs
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding virtualization support to the DataGrid when fetching data from the server via ServerData.
Description
In my previous PR (#9019), I made a significant mistake.
Using GridState with Page and PageSize properties is incorrect. The Virtualize component passes the StartIndex property through ItemsProvider, from which PageNumber cannot be calculated.
In the new version, I added VirtualizeServerData since it is necessary to return a new model with correct StartIndex and Count properties. Additionally, it was an oversight not to include the Placeholder property in mudVirtualize, as without placeholder rows of the same height as other rows, virtualization does not work correctly. This has been fixed.
Type of Changes
Checklist