MudDataGrid: Fix column resizing in RTL (#6965)#9073
Merged
henon merged 5 commits intoMudBlazor:devfrom May 29, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9073 +/- ##
==========================================
+ Coverage 89.82% 90.63% +0.80%
==========================================
Files 412 398 -14
Lines 11878 12380 +502
Branches 2364 2405 +41
==========================================
+ Hits 10670 11220 +550
+ Misses 681 621 -60
- Partials 527 539 +12 ☔ View full report in Codecov by Sentry. |
Member
|
Hi, Thanks for the PR. You can run "dotnet format" from the command line if you are struggling to fix the white spaces. |
ScarletKuro
reviewed
May 28, 2024
src/MudBlazor/Components/DataGrid/DataGridColumnResizeService.cs
Outdated
Show resolved
Hide resolved
src/MudBlazor/Components/DataGrid/DataGridColumnResizeService.cs
Outdated
Show resolved
Hide resolved
src/MudBlazor.Docs/Pages/Components/DataGrid/Examples/DataGridResizeExample.razor
Outdated
Show resolved
Hide resolved
Member
|
@henon, I don't think we need to involve @tjscience here if you tell me this code looks reasonable to you. |
Contributor
Author
|
Thanks for the review, I've implemented the changes you requested. |
danielchalmers
added
the
accessibility
henon
added
rtl
and removed
docs
henon
changed the title
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this fixes a one part of the issue, it currently fixes only the resize for the column in rtl
I've also updated the doc to move the non resizable column to the second column
resize.issue.before.mp4
after.mp4
How Has This Been Tested?
I ran all the unit tests, and I've visually tested it, haven't actually modified any unit test.
Type of Changes
Checklist
dev).