@igotinfected Thanks for all your help, I've got another for you. This time I'm doing refinement on earlier PRs in addition to more localization. I realized I added too many aria-labels which is more harmful than anything. If a button (for example) already has text, it really doesn't need a label as well. Icon buttons are where they come in best.

Speaking of icons, I'm not sure it's right that we hide all icons from screen readers:

Seems like it's the right thing only if they are decorative or already described by a label?

Do you know what's up with this error @ScarletKuro ?

System.InvalidOperationException : Cannot provide a value for property 'Localizer' on type 'MudBlazor.MudInput`1[[System.String, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]'. There is no registered service of type 'MudBlazor.InternalMudLocalizer'.

Do you know what's up with this error @ScarletKuro ?

Look at the test, it's using a context that has no mudblazor services registered at all.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (28bc599) to head (9f7bd20).
Report is 242 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #9071      +/-   ##
==========================================
+ Coverage   89.82%   90.63%   +0.80%     
==========================================
  Files         412      398      -14     
  Lines       11878    12378     +500     
  Branches     2364     2405      +41     
==========================================
+ Hits        10670    11219     +549     
+ Misses        681      621      -60     
- Partials      527      538      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also for the resource keys I would suggest not using punctuation/special characters in the resources to be able to use static references (in reference to the MudDataGrid keys). It's probably something that will be caught in the PR reviews but one less worry in general ;)

Also for the resource keys I would suggest not using punctuation/special characters in the resources to be able to use static references (in reference to the MudDataGrid keys). It's probably something that will be caught in the PR reviews but one less worry in general ;)

Yes! I tried to fix all that but it didn't render properly due to the weird markup and all the text was literally "MudDataGrid_etcetc", then I couldn't figure out how the punctuation was actually used. Didn't have time to familiarize myself with the technicalities so just reverted the changes :(

@henon Ready to review

Also for the resource keys I would suggest not using punctuation/special characters in the resources to be able to use static references (in reference to the MudDataGrid keys). It's probably something that will be caught in the PR reviews but one less worry in general ;)

Should we change the datagrid keys? Though it will be a breaking change :( I dislike that we now have inconsistencies where some use . and some use _.

Also for the resource keys I would suggest not using punctuation/special characters in the resources to be able to use static references (in reference to the MudDataGrid keys). It's probably something that will be caught in the PR reviews but one less worry in general ;)

Should we change the datagrid keys? Though it will be a breaking change :( I dislike that we now have inconsistencies where some use . and some use _.

@ScarletKuro Take a look at bd0d536 and see if you can figure out why it renders the keys literally (The filter placeholder will say "MudDataGrid_FilterValue")

@ScarletKuro Take a look at bd0d536 and see if you can figure out why it renders the keys literally (The filter placeholder will say "MudDataGrid_FilterValue")

If you look at LanguageResource.resx, the XML keys are with a dot name="MudDataGrid.Ungroup", but the code generator can't use . so it generates the language resource designer property with an underscore MudDataGrid_Ungroup. However, that's just the property name for the static reference, not the key name. That's why when you use nameof, it will return the property name with an underscore, but not its underlying key. This is why it uses @Localizer["MudDataGrid.Ungroup"]. Using nameof is actually incorrect, as the property name is not equal to the key. At least I haven't seen this practice when people use a custom localizer (like we do) instead of a static reference like @LanguageResource.MudDataGrid_Ungroup. However, we cannot use the latter since we allow overriding translations, using interceptors, etc.

@ScarletKuro So weird, thanks for the explanation. What do you think we should do about it? I can do the bulk of the refactoring

Also for the resource keys I would suggest not using punctuation/special characters in the resources to be able to use static references (in reference to the MudDataGrid keys). It's probably something that will be caught in the PR reviews but one less worry in general ;)

Should we change the datagrid keys? Though it will be a breaking change :( I dislike that we now have inconsistencies where some use . and some use _.

We'll do it but not in v7. Let's just put it on our list and at some time when we make another major version and don't have a massive change set we'll do it. Adding this to the v8 project, but we don't necessarily have to do it in v8, it can wait.

Is this ready to merge?

Is this ready to merge?

@henon Yes

EDIT: Wait for @jperson2000

@jperson2000 Mind taking a look at these doc changes?

@henon Ready to merge!

Thanks