Skip to content

MudRating: Fix Color regression #5463#9069

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:rating_fix
May 27, 2024
Merged

MudRating: Fix Color regression #5463#9069
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:rating_fix

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented May 27, 2024 •
edited
Loading

Description

Regression was done here: #5463
Fix: #9062

First of all, it should not modify the external parameter Color.
Second, we should only fill the SVG colors and not change the class mud-{Color.ToDescriptionString()}-text.
Third, we should use Color.Inherit as it is the default for MudIcon.

How Has This Been Tested?

Visual, adjusted test

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels May 27, 2024
@codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (28bc599) to head (392314a).
Report is 1103 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9069      +/-   ##
==========================================
+ Coverage   89.82%   90.63%   +0.80%     
==========================================
  Files         412      398      -14     
  Lines       11878    12380     +502     
  Branches     2364     2405      +41     
==========================================
+ Hits        10670    11221     +551     
+ Misses        681      621      -60     
- Partials      527      538      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro ScarletKuro changed the title Rating fix MudRating: Fix Color regression May 27, 2024
@ScarletKuro ScarletKuro changed the title MudRating: Fix Color regression MudRating: Fix Color regression #5463 May 27, 2024
@ScarletKuro ScarletKuro merged commit 083e455 into MudBlazor:dev May 27, 2024
@ScarletKuro ScarletKuro deleted the rating_fix branch May 27, 2024 18:06
@danielchalmers danielchalmers added regression Previously worked and now doesn't and removed accidental break labels Jul 1, 2025
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended regression Previously worked and now doesn't

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MudRating icons are gray

2 participants

@ScarletKuro @danielchalmers