MudCollapse, MudStack, MudToolbar: Improve accessibility#9059
MudCollapse, MudStack, MudToolbar: Improve accessibility#9059henon merged 3 commits intoMudBlazor:devfrom
Conversation
MudCollapse - Add `aria-expanded="@expanded"` MudMainContent - Use semantic `main` tag instead of plain `div` MudStack - Add `role="group"`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9059 +/- ##
==========================================
+ Coverage 89.82% 90.65% +0.82%
==========================================
Files 412 398 -14
Lines 11878 12376 +498
Branches 2364 2403 +39
==========================================
+ Hits 10670 11219 +549
+ Misses 681 620 -61
- Partials 527 537 +10 ☔ View full report in Codecov by Sentry. |
|
cc @igotinfected 2 of 3 |
|
@igotinfected Do you think MudCard should use |
|
@igotinfected Replaced MudMainContent improvements with MudToolbar |
Awesome! Like for |
|
@henon Ready for review |
jperson2000
left a comment
There was a problem hiding this comment.
LGTM. These are great improvements, and ya even fixed up the docs. Do you want to know of other Toolbar components to update? I wasn't sure if you had a plan for those already.
@jperson2000 I'd love to know what you have in mind! I'm doing it pretty much at random for the low hanging fruit right now |
Description
MudCollapse
aria-expanded="@Expanded"MudStack
role="group"MudToolbar
role="toolbar"How Has This Been Tested?
visually
Type of Changes
Checklist
dev).