TimeSeriesChart: Add time label format option for time series chart#9049
Conversation
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9049 +/- ##
==========================================
+ Coverage 89.82% 90.62% +0.79%
==========================================
Files 412 398 -14
Lines 11878 12372 +494
Branches 2364 2403 +39
==========================================
+ Hits 10670 11212 +542
+ Misses 681 621 -60
- Partials 527 539 +12 ☔ View full report in Codecov by Sentry. |
|
Hi, Thanks for the PR. Can you add a very simple bUnit test with a custom |
ScarletKuro
added
the
needs: tests
|
Test has been added now |
ScarletKuro
removed
the
needs: tests
|
Thanks |
|
My bad I had intended for it to have a date/time format but I must have missed that with tunnel vision! |
|
@jorisBarkema I also thought about making the labels be able to have an angle to make it work better in higher density data. I.e. 30-45 degree angle labels. Otherwise did you find it a good chart? |
|
Yeah it was very easy to work with and did exactly what I wanted to do. So far at least because some other things have come up after I started on this. |
4 participants
The time label format was hardcoded at HH:mm, but I wanted a chart over several days. This format does not make sense in that case so I wanted a way to show the date in the time label.
Description
Add a parameter similar to TimeLabelSpacing to be able to set the TimeLabelFormat. Default to the value that was previously hardcoded to maintain backwards compatability.
How Has This Been Tested?
The TimeSeries component as a whole has no tests yet (#8973 see last comments) so can't add a test for just this feature without testing the whole thing and I sadly don't have time for that.
Type of Changes
Example of a time series with datelabel format "dd/MM HH:mm"
Checklist
dev).