Skip to content

Autocomplete: Give async methods Async suffix#8990

Merged
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:autocomplete-async-api
May 18, 2024
Merged

Autocomplete: Give async methods Async suffix#8990
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:autocomplete-async-api

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented May 17, 2024 •
edited by henon
Loading

Description

Renamed SelectOption to SelectOptionAsync #8990
Renamed Clear to ClearAsync #8990

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers
Copy link
Member Author

danielchalmers commented May 17, 2024

@henon here ya go #8914 (comment)

@codecov
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.45%. Comparing base (28bc599) to head (3097bb2).
Report is 206 commits behind head on dev.

Files Patch % Lines
...r/Components/Autocomplete/MudAutocomplete.razor.cs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8990      +/-   ##
==========================================
+ Coverage   89.82%   90.45%   +0.62%     
==========================================
  Files         412      396      -16     
  Lines       11878    12127     +249     
  Branches     2364     2364              
==========================================
+ Hits        10670    10970     +300     
+ Misses        681      623      -58     
- Partials      527      534       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro added the breaking change This change will require consumer code updates label May 17, 2024
@ScarletKuro ScarletKuro requested review from ScarletKuro and henon May 17, 2024 13:52
@ScarletKuro ScarletKuro added the API change Modifies the public API surface label May 17, 2024
@henon henon merged commit b8277cc into MudBlazor:dev May 18, 2024
@henon
Copy link
Contributor

henon commented May 18, 2024

Thanks

@henon henon mentioned this pull request May 18, 2024
Closed
@danielchalmers danielchalmers deleted the autocomplete-async-api branch May 18, 2024 20:07
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielchalmers @henon @ScarletKuro