MudAvatar, MudAvatarGroup, MudBadge: Improve accessibility#8986
Merged
henon merged 3 commits intoMudBlazor:devfrom May 19, 2024
Merged
MudAvatar, MudAvatarGroup, MudBadge: Improve accessibility#8986henon merged 3 commits intoMudBlazor:devfrom
henon merged 3 commits intoMudBlazor:devfrom
Conversation
Avatar: - Add role="img" to the <div> element to indicate that it is an image or avatar. AvatarGroup: - Add role="group" to the <div> to indicate it's a group. Badge: - Add role="status" and aria-live="polite" to the outer to make screen readers aware of any updates to the badge content. - Add BadgeAriaLabel - Rename BadgeClassName to BadgeClassname - Fix markup using tabs instead of spaces - I didn't make the badge keyboard accessible due to added complexity but it should be if it's also clickable
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8986 +/- ##
==========================================
+ Coverage 89.82% 90.48% +0.65%
==========================================
Files 412 396 -16
Lines 11878 12127 +249
Branches 2364 2364
==========================================
+ Hits 10670 10973 +303
+ Misses 681 621 -60
- Partials 527 533 +6 ☔ View full report in Codecov by Sentry. |
This reverts commit 960e749.
henon
reviewed
May 18, 2024
Contributor
|
@igotinfected FYI |
Contributor
|
Thanks Daniel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of series in #8901
Avatar:
<div>element to indicate that it is an image or avatar.AvatarGroup:
<div>to indicate it's a group.Badge:
Use a<div>instead of a<span>for the badge root container so it's properly a block elementHow Has This Been Tested?
unit
Type of Changes
Checklist
dev).