Skip to content

MudTable: Use theme typography for font size#8984

Closed
neozhu wants to merge 6 commits intoMudBlazor:devfrom
neozhu:tablefontsize
Closed

MudTable: Use theme typography for font size#8984
neozhu wants to merge 6 commits intoMudBlazor:devfrom
neozhu:tablefontsize

Conversation

@neozhu
Copy link
Contributor

@neozhu neozhu commented May 16, 2024

Description:

This PR modifies the _table.scss file by changing the font-size property from 0.875 to inherit.

Changes:

  • Updated _table.scss:
    • font-size: 0.875 -> font-size: inherit

Benefits:

  • This change allows the font size in tables and datagrids to be synchronized with the default font size defined in the Theme. This ensures consistency in typography across the application and makes it easier to manage font sizes through the Theme settings.

Testing:

  • Verified that tables and datagrids now use the inherited font size from the Theme.
  • Checked for any visual regressions to ensure the change does not negatively impact the UI.

@neozhu neozhu changed the title Update _table.scss to Use Inherited Font Size* Update _table.scss to Use Inherited Font Size May 16, 2024
@ScarletKuro ScarletKuro added the enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library label May 16, 2024
@danielchalmers
Copy link
Member

danielchalmers commented May 16, 2024

does the line-height and letter-spacing need to be inherited too?

@neozhu
Update _table.scss
eaa60c9 
line-height,letter-spacing: inherit;
@codecov
Copy link

codecov bot commented May 17, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.57%. Comparing base (28bc599) to head (b1de178).
⚠️ Report is 1335 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8984      +/-   ##
==========================================
+ Coverage   89.82%   90.57%   +0.74%     
==========================================
  Files         412      397      -15     
  Lines       11878    12313     +435     
  Branches     2364     2396      +32     
==========================================
+ Hits        10670    11153     +483     
+ Misses        681      621      -60     
- Partials      527      539      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielchalmers
Copy link
Member

danielchalmers commented May 17, 2024

Like this in a few components:

Need to check with @Garderoben if it's intentional

@danielchalmers danielchalmers requested a review from Garderoben July 5, 2024 06:05
Garderoben
Garderoben requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@Garderoben Garderoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this but rather want it to use the themes body2 for font instead of inherit.

@danielchalmers
Copy link
Member

danielchalmers commented Nov 16, 2024

We talked about this but rather want it to use the themes body2 for font instead of inherit.

See .mdc-data-table__content, .mdc-data-table__cell, etc from Data tables - Material Design.

@danielchalmers danielchalmers removed the request for review from henon November 16, 2024 02:55
@danielchalmers danielchalmers mentioned this pull request Dec 20, 2024
Open
4 tasks
@danielchalmers danielchalmers mentioned this pull request Apr 4, 2025
Open
2 tasks
@github-actions github-actions bot changed the title Update _table.scss to Use Inherited Font Size MudTable: Use theme typography for font size Aug 3, 2025
@github-actions github-actions bot added the stale Issue or PR has had no activity and is subject to automatic closure if not updated label Aug 20, 2025
@github-actions
Copy link

github-actions bot commented Aug 20, 2025

Hi, this pull request hasn't had activity in a while and has been marked as stale.

Please reply if you're still working on it!

@mudbot mudbot bot added the needs: changes A maintainer has asked for further modifications to be made to this pull request label Sep 30, 2025
@danielchalmers danielchalmers mentioned this pull request Nov 2, 2025
Closed
@danielchalmers
Copy link
Member

danielchalmers commented Nov 2, 2025

Moved to #12045

Copilot AI mentioned this pull request Nov 23, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garderoben Garderoben Garderoben requested changes

@danielchalmers danielchalmers Awaiting requested review from danielchalmers

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library needs: changes A maintainer has asked for further modifications to be made to this pull request stale Issue or PR has had no activity and is subject to automatic closure if not updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neozhu @danielchalmers @Garderoben @ScarletKuro