MudNavGroup: Use ParameterState framework#8980
Merged
henon merged 1 commit intoMudBlazor:devfrom May 15, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8980 +/- ##
==========================================
+ Coverage 89.82% 90.48% +0.65%
==========================================
Files 412 396 -16
Lines 11878 12127 +249
Branches 2364 2364
==========================================
+ Hits 10670 10973 +303
+ Misses 681 621 -60
- Partials 527 533 +6 ☔ View full report in Codecov by Sentry. |
henon
reviewed
May 15, 2024
Comment on lines
138
to
144
| private void UpdateNavigationContext() | ||
| => _navigationContext = _navigationContext with | ||
| { | ||
| Disabled = Disabled || _parentNavigationContextState.Value is { Disabled: true }, | ||
| Expanded = _expanded | ||
| Disabled = _disabledState.Value || _parentNavigationContextState.Value is { Disabled: true }, | ||
| Expanded = _expandedState.Value | ||
| && _parentNavigationContextState.Value is null or { Expanded: true } | ||
| }; |
Contributor
There was a problem hiding this comment.
This code is horrible. Not your changes, it was already a coding horror. I really don't understand what it does.
Member
Author
There was a problem hiding this comment.
It was added in this PR: #8684
I introduced a NavigationContext that allows passing state down a navigation group chain which allows us to figure out whether buttons/links at a specific level of the chain should be focusable via keyboard navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Get rid of BL0007
How Has This Been Tested?
Visually, existing tests pass
Type of Changes
Checklist
dev).