Skip to content

MudMask: Remove CatchAndLog usage#8970

Merged
henon merged 3 commits intoMudBlazor:devfrom
ScarletKuro:task_fix
May 15, 2024
Merged

MudMask: Remove CatchAndLog usage#8970
henon merged 3 commits intoMudBlazor:devfrom
ScarletKuro:task_fix

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented May 14, 2024

Description

We should decrease CatchAndLog and async void usage.

How Has This Been Tested?

Just the current unit testing

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro changed the title MudMask: Remove CatchAndLog MudMask: Remove CatchAndLog usage May 14, 2024
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels May 14, 2024
@codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (28bc599) to head (dc86358).
Report is 200 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8970      +/-   ##
==========================================
+ Coverage   89.82%   90.46%   +0.63%     
==========================================
  Files         412      420       +8     
  Lines       11878    12199     +321     
  Branches     2364     2382      +18     
==========================================
+ Hits        10670    11036     +366     
+ Misses        681      627      -54     
- Partials      527      536       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon May 14, 2024 22:55
@henon
Copy link
Contributor

henon commented May 15, 2024

Code changes look good. Did you try the mask on BSS with your changes?

@ScarletKuro
Copy link
Member Author

ScarletKuro commented May 15, 2024 •
edited
Loading

Code changes look good. Did you try the mask on BSS with your changes?

Yeah. locally at least I see no difference.

@henon henon merged commit 707b478 into MudBlazor:dev May 15, 2024
@ScarletKuro ScarletKuro deleted the task_fix branch May 15, 2024 10:07
danielchalmers pushed a commit to danielchalmers/MudBlazor that referenced this pull request May 15, 2024
@ScarletKuro @danielchalmers
MudMask: Remove CatchAndLog usage (MudBlazor#8970)
cb5f63a
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScarletKuro @henon