Dialog: Fix possible deadlock#8964
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom May 13, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8964 +/- ##
==========================================
+ Coverage 89.82% 90.48% +0.65%
==========================================
Files 412 419 +7
Lines 11878 12211 +333
Branches 2364 2385 +21
==========================================
+ Hits 10670 11049 +379
+ Misses 681 627 -54
- Partials 527 535 +8 ☔ View full report in Codecov by Sentry. |
danielchalmers
added a commit
to danielchalmers/MudBlazor
that referenced
this pull request
May 21, 2024
Reverts MudBlazor#8964 Caused timing issues
7 tasks
ScarletKuro
added a commit
that referenced
this pull request
May 25, 2024
Co-authored-by: Artyom M <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Possible fix to #8961?
According to Async Guidance it always preferable to create
TaskCompletionSourcewithTaskCreationOptions.RunContinuationsAsynchronouslyoverload: https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#always-create-taskcompletionsourcet-with-taskcreationoptionsruncontinuationsasynchronouslyAlso similar thing was done in Blazored/Modal: Blazored/Modal#408
How Has This Been Tested?
Would be nice to have a bUnit test, but I don't have any example that runs into that problem.
Type of Changes
Checklist
dev).