Tests: fix slider tests failing on certain cultures#8949
Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom May 12, 2024
Merged
Tests: fix slider tests failing on certain cultures#8949ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro merged 2 commits intoMudBlazor:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8949 +/- ##
==========================================
+ Coverage 89.82% 90.46% +0.63%
==========================================
Files 412 419 +7
Lines 11878 12197 +319
Branches 2364 2381 +17
==========================================
+ Hits 10670 11034 +364
+ Misses 681 628 -53
- Partials 527 535 +8 ☔ View full report in Codecov by Sentry. |
Member
|
Should we maybe just set |
Contributor
Author
|
I don't mind for the tests, will change. But even if the converters are reworked they will do exactly this job, converting to and from string using a specified culture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two slider tests failed on my locale. Made sure they work everywhere the same.