Utilities: Increase max spacing/gap to 20 from 16#8943
Merged
henon merged 1 commit intoMudBlazor:devfrom May 11, 2024
Merged
Conversation
80px up from 64px. Resolves MudBlazor#8942
github-actions
bot
added
enhancement
Member
Author
|
20 was suggested by @henon due to Bootstrap only offering up to 20, Vuetify the same |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8943 +/- ##
==========================================
+ Coverage 89.82% 90.45% +0.62%
==========================================
Files 412 419 +7
Lines 11878 12190 +312
Branches 2364 2380 +16
==========================================
+ Hits 10670 11026 +356
+ Misses 681 630 -51
- Partials 527 534 +7 ☔ View full report in Codecov by Sentry. |
Contributor
|
I did misremember. Vuetify offers only up to 16. But Bootstrap offers up to 20 and is used by so many that I guess it is a good idea to orient ourselves after them with respect to these classes. |
Contributor
|
Does it increase padding utility classes also? i.e. |
Member
Author
@henon Yes, they're listed under Spacing
|
ScarletKuro
approved these changes
May 10, 2024
Contributor
|
Thanks! |
Namoshek
added a commit
to Namoshek/MudBlazor
that referenced
this pull request
Jul 29, 2024
The spacing have been extended in MudBlazor#8943 without updating the documentation.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
80px up from 64px.
Resolves #8942
MudForm now allows
gap-0MudStack no longer allows negative gap which was invalid and adds more documentation
Not sure if I missed any.
How Has This Been Tested?
Type of Changes
Checklist
dev).