MudContainer: Add Gutters property#8934
Merged
henon merged 2 commits intoMudBlazor:devfrom May 11, 2024
Merged
Conversation
Interestingly there was an unused `mud-container-disable-gutters` but I reversed the way the padding is handled in a fashion like MudBlazor#8586. Normally it's added then removed. This way it's only added in the first place if Gutters is actually enabled. This means we dont have to mess around with `!important` and ruin people's overrides.
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8934 +/- ##
==========================================
+ Coverage 89.82% 90.45% +0.62%
==========================================
Files 412 419 +7
Lines 11878 12190 +312
Branches 2364 2380 +16
==========================================
+ Hits 10670 11026 +356
+ Misses 681 630 -51
- Partials 527 534 +7 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I use the MudContainer and currently have to override the styles to avoid the extra padding added. This lets you control it with a property like several other controls.
Interestingly there was an unused
mud-container-disable-gutters, but I reversed the way the padding is handled in a fashion like #8586. Normally it's added then removed but this way it's only added if Gutters is actually enabled in the first place. This should be the general convention IMO because it avoid usage of!importantwhich messes with consumers' overrides.How Has This Been Tested?
unit, visually
Type of Changes
Default vs Gutters=false
Checklist
dev).