MudDatePicker: Fix GoToDate with Persian calendar#8909
Merged
henon merged 5 commits intoMudBlazor:devfrom May 8, 2024
Merged
Conversation
2 tasks
Member
|
Hi. |
Contributor
|
@ajahangard please understand that by providing a test for your fix you'll ensure that further work on the date picker will never ever break it again, at least not this aspect ;) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8909 +/- ##
==========================================
+ Coverage 89.82% 90.26% +0.43%
==========================================
Files 412 425 +13
Lines 11878 12294 +416
Branches 2364 2409 +45
==========================================
+ Hits 10670 11097 +427
+ Misses 681 667 -14
- Partials 527 530 +3 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@henon @ScarletKuro , |
ScarletKuro
approved these changes
May 8, 2024
Contributor
|
Thanks @ajahangard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved issue #8905 in GoToDate() methods in MudDatePicker
Description
Fixes: #8905
How Has This Been Tested?
I have tested it manually.
I added relevant test case.
Type of Changes
Checklist
dev).