Standardise the use of ItemDisabled#8887
Merged
henon merged 2 commits intoMudBlazor:devfrom May 7, 2024
Merged
Conversation
github-actions
bot
added
breaking change
This was referenced May 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8887 +/- ##
==========================================
+ Coverage 89.82% 90.18% +0.35%
==========================================
Files 412 423 +11
Lines 11878 12274 +396
Branches 2364 2407 +43
==========================================
+ Hits 10670 11069 +399
+ Misses 681 670 -11
- Partials 527 535 +8 ☔ View full report in Codecov by Sentry. |
danielchalmers
approved these changes
May 6, 2024
Closed
Contributor
|
Thanks @BieleckiLtd Added to v7.0.0 Migration Guide #8447 |
This was referenced May 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MudBlazor currently uses the
ItemIsDisabledproperty. This PR aims to standardise the use ofItemDisabledto align with other boolean properties in the library.Description
If this PR is approved, the v7 migration guide must also be updated, as this makes a breaking change:
MudDropZone: replace
ItemIsDisabledwithItemDisabledMudDropContainer: replace
ItemIsDisabledwithItemDisabledLinked issues:
Negative property names should be discouraged #6131
v7.0.0 Migration Guide #8447
Standardise the use of
IsEnabledandEnabled#8764Standardise the use of
ItemDisabled#8887Standardise the use of
Checked,CheckedChangedandCheckable#8825Standardise the use of
Visible#8832Standardise the use of
SelectedandSelectedChanged#8886Standardise the use of
Expanded,Expandable,IsExpandedandIsExpandable#8718Standardise the use of
Active#8888Standardise the use of
OpenandOpenChanged#8891Standardise the use of
Editable#8892Standardise the use of
HiddenandHiddenChanged#8952How Has This Been Tested?
unit
Type of Changes
Checklist
dev).