Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (28bc599) to head (13870bb).
Report is 163 commits behind head on dev.

❗ Current head 13870bb differs from pull request most recent head e20984b. Consider uploading reports for the commit e20984b to get more accurate results

@@            Coverage Diff             @@
##              dev    #8880      +/-   ##
==========================================
+ Coverage   89.82%   90.18%   +0.35%     
==========================================
  Files         412      423      +11     
  Lines       11878    12275     +397     
  Branches     2364     2407      +43     
==========================================
+ Hits        10670    11070     +400     
+ Misses        681      670      -11     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LGTM, just a test is missing. That check for the application of the class
As for unifying spacing between the various components I'd say let's do it in a separate PR.

@henon Test added. Do you want me to squeeze in the spacing unification before preview2?

Do you want me to squeeze in the spacing unification before preview2?

No hurry. We'll do as many previews as we need.

You may want to consider adding this to the v7 migration guide, as changing the display from block to flex on the form has caused formatting issues for our application, as our form child components were not expected to be in a flex container. I completely understand the usefulness of the change, but legacy implementations that set their own spacing/layout may now have to tweak. Easy enough to fix with a single wrapper div in the form or a Style change, but it's one of those things that is subtle and doesn't show up in unit testing.

Some issues...

• Stand alone buttons without a div wrapper are now 100% the form width.
• Divs with display flex inside the form now have additional spacing/margins that conflict with controls around them which are captured in the forms flex box.

A potential backward compatible fix would be to have the form be display:block if the new spacing parameter is not set.

I would humbly suggest any changes to a container's CSS "display" value be listed as a potential breaking change in the future.

Thanks for the feedback. I added this to the migration guide: #8447