MudIcon: Fix icon color when disabled#8869
Conversation
github-actions
bot
added
breaking change
|
@henon @JonBunator @ScarletKuro I hope this is what you had in mind otherwise I am open for feedback. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8869 +/- ##
==========================================
+ Coverage 89.82% 90.12% +0.29%
==========================================
Files 412 421 +9
Lines 11878 12304 +426
Branches 2364 2431 +67
==========================================
+ Hits 10670 11089 +419
+ Misses 681 666 -15
- Partials 527 549 +22 ☔ View full report in Codecov by Sentry. |
Good idea! Thanks for that |
|
Fixed the parts @ScarletKuro pointed out. Should be ready now. Sorry about the tagging in the commit message 😅 |
|
@dennisrahmen please run |
|
Thanks Dennis! |
4 participants
Description
This is a continuation of #7245 which aimed at fixing the color of a menu item that has a custom color set which then overrides the disabled color when the menu item is disabled.
In the mentioned pull request I fixed it by not propagating the custom color to the icon when the component is disabled and with that fixed it for this one component.
But since there are multiple components that use
MudIconthis propagation logic would have to be added to each component so I opted to add a 'Disabled' property to the 'MudIcon' instead and propagated the disabled state from the components to the icon.I checked all components for the use of
MudIcon, especiallyMudTreeViewandMudListsince those components use multiple icons for the list items and the expansion/collapse.List disabled with this pr:
List disabled before this pr:
How Has This Been Tested?
visually
Type of Changes
Checklist
dev).