Fixed

Glitchy open on firefox

Multiple opens during long search

Menu re-opening on item select

Menu opens after clicking away

@ScarletKuro Could you try your scenarios with this PR and help me with the remaining tests?

@henon @ScarletKuro Why does the SearchFunc throw an exception here

Please set a breakpoint and find out what the exception and the stacktrace are and post it here.

@henon

''<' is an invalid start of a value. Path: $ | LineNumber: 0 | BytePositionInLine: 0.'

' at System.Text.Json.ThrowHelper.ReThrowWithPath(ReadStack& state, JsonReaderException ex)\n at System.Text.Json.Serialization.JsonConverter`1[[System.Collections.Generic.List`1[[MudBlazor.Examples.Data.Models.Element, MudBlazor.Examples.Data, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]], System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)\n at System.Text.Jso…xample.Search(String value, CancellationToken token) in C:\Users\danie\source\repos\MudBlazor\src\MudBlazor.Docs\Pages\Components\Autocomplete\Examples\AutocompleteStrictFalseExample.razor:line 25\n at MudBlazor.MudAutocomplete`1.d__188[[MudBlazor.Examples.Data.Models.Element, MudBlazor.Examples.Data, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext() in C:\Users\danie\source\repos\MudBlazor\src\MudBlazor\Components\Autocomplete\MudAutocomplete.razor.cs:line 649'

@henon @ScarletKuro Why does the SearchFunc throw an exception here

Sorry, but I really don't know. I have no codebase knowledge on how this component functions at slightest. @henon @mckaragoz has more experience with this component.
It's also hard for me to adequately review this when I don't know the nuances and you changed many places. I'd say this component code resembles delicate paper, susceptible to crumbling with the slightest disturbance 😳 Because it has many race conditions and my async void -> Task change is a proof of this (nvm, it was MudSelect but they have the same problems). I appropriate your effort on trying to fix it tho, but almost feels like it would be better to make a parallel component called "MudAutocompleteX" and do minimum at least for the mudblazor docs search, battle test it there and then extend the functionality.

@ScarletKuro I think I've definitely hardened the code and made it less brittle and susceptible to race conditions. It does need some heavy testing though. I would hate to discard these changes from the BCL because it has a lot of improvements for all users.

The exception means that the json coming from the web api is invalid. For whatever reason. I can't see why your changes would cause that

Maybe you can find out what the api call returns that can't be parsed?

Maybe you can find out what the api call returns that can't be parsed?

Probably the result is returned as plain text (server error) while json is expected.

@henon @Yomodo Seeing it with this call:

await SearchFunc(null, _cancellationTokenSrc.Token);

In AutocompleteStrictFalseExample.razor:

    private async Task<IEnumerable<Element>> Search(string value, CancellationToken token)
    {
        return await httpClient.GetFromJsonAsync<List<Element>>($"webapi/periodictable/{value}", token);
    }

and AutocompleteStrictFalseSelectedHighlight.razor:

    public async Task<IEnumerable<string>> Search(string text, CancellationToken token)
    {
		await Task.Delay(100, token);

		if (string.IsNullOrWhiteSpace(text))
		{
			return Fruits;
		}

		return Fruits.Where(x => x.Contains(text, StringComparison.InvariantCulture));
	}

Can you see any reason it would stop working?

Does it even work without your changes?

Does it even work without your changes?

@henon Works on https://dev.mudblazor.com/components/autocomplete#strict-mode

@henon

''<' is an invalid start of a value. Path: $ | LineNumber: 0 | BytePositionInLine: 0.'
' at System.Text.Json.ThrowHelper.ReThrowWithPath(ReadStack& state, JsonReaderException ex)\n at System.Text.Json.Serialization.JsonConverter1[[System.Collections.Generic.List1[[MudBlazor.Examples.Data.Models.Element, MudBlazor.Examples.Data, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]], System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)\n at System.Text.Jso…xample.Search(String value, CancellationToken token) in C:\Users\danie\source\repos\MudBlazor\src\MudBlazor.Docs\Pages\Components\Autocomplete\Examples\AutocompleteStrictFalseExample.razor:line 25\n at MudBlazor.MudAutocomplete`1.d__188[[MudBlazor.Examples.Data.Models.Element, MudBlazor.Examples.Data, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext() in C:\Users\danie\source\repos\MudBlazor\src\MudBlazor\Components\Autocomplete\MudAutocomplete.razor.cs:line 649'

@danielchalmers I've seen this error before when I expect JSON but get HTML, such as when I forget to authenticate an HttpClient request. If we can get the raw response from the HttpClient, then we can look at the actual response content and dig deeper. Here's some temporary code which should do the trick:

  private async Task<IEnumerable<Element>> Search(string value, CancellationToken token)
    {
        // return await httpClient.GetFromJsonAsync<List<Element>>($"webapi/periodictable/{value}", token);
        var response = await httpClient.GetAsync($"webapi/periodictable/{value}", token);
        var content = await response.Content.ReadAsStringAsync();
        Debugger.Break(); // Examine the content variable here for issues, maybe an auth error?
        return JsonSerializer.Deserialize<List<Element>>(content);
    }

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.12%. Comparing base (28bc599) to head (6451e72).
Report is 117 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #8787      +/-   ##
==========================================
+ Coverage   89.82%   90.12%   +0.29%     
==========================================
  Files         412      421       +9     
  Lines       11878    12213     +335     
  Branches     2364     2410      +46     
==========================================
+ Hits        10670    11007     +337     
+ Misses        681      664      -17     
- Partials      527      542      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Does it even work without your changes?

@henon Works on https://dev.mudblazor.com/components/autocomplete#strict-mode

Yes, but try to execute it locally instead from dev.mudblazor.ocm. It may well be the cause of the error.

@henon Should have pinged you above but I got it all working except the example because the webapi returns 404 in debug mode which is not a regression. PR should be ready to review

Thanks for the great tip, it made me discover that the webapi returns 404

Are you starting docs as wasm standalone? There is WasmHost then the API should be available.

The Strict parameter and example troubles me. I can't think of a use-case where you want the Strict="true" behavior because it will show an empty dropdown when clicking the autocomplete which is just nonsense. I remember that this behavior was the default in the beginning. We added the parameter to avoid a breaking change because users wanted the Strict="false" behavior instead.

Unless somebody can think of a valid use-case for Strict="true" I would now consider taking the opportunity and making the breaking change of just removing this parameter.

Thanks for the great tip, it made me discover that the webapi returns 404

Are you starting docs as wasm standalone? There is WasmHost then the API should be available.

Yes this. wasm standalone doesnt have any mvc controllers to provide the endpoints for the examples data.

We want to retain the Strict==false behavior and remove the Strict==true behavior.

@Mr-Technician @ScarletKuro Looks good?

EDIT: Wait for Mr-Technician before merging