Skip to content

MudSelect: Revert #8309#8770

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:select_revert
Apr 21, 2024
Merged

MudSelect: Revert #8309#8770
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:select_revert

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 21, 2024

Description

Fixes: #8659
Regression after: #8309
We decided that reverting it for MudSelect is best option, as the component is kind of broken and trying to fix it is too time confusing.

How Has This Been Tested?

Visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Apr 21, 2024
@ScarletKuro ScarletKuro mentioned this pull request Apr 21, 2024
Closed
2 tasks
@codecov
Copy link

codecov bot commented Apr 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (28bc599) to head (218a53a).
Report is 1103 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8770      +/-   ##
==========================================
+ Coverage   89.82%   90.02%   +0.19%     
==========================================
  Files         412      419       +7     
  Lines       11878    12180     +302     
  Branches     2364     2400      +36     
==========================================
+ Hits        10670    10965     +295     
+ Misses        681      670      -11     
- Partials      527      545      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro ScarletKuro merged commit 0eaf031 into MudBlazor:dev Apr 21, 2024
@ScarletKuro ScarletKuro deleted the select_revert branch April 21, 2024 16:51
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@ScarletKuro @biegehydra
MudSelect: Revert MudBlazor#8309 (MudBlazor#8770)
21d634d
@ScarletKuro ScarletKuro mentioned this pull request Oct 29, 2024
Merged
7 tasks
@danielchalmers danielchalmers added regression Previously worked and now doesn't and removed accidental break labels Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended regression Previously worked and now doesn't

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MudSelect : first click is sometimes ignored

2 participants

@ScarletKuro @danielchalmers