CssBuilder, StyleBuilder: Fix method with optional parameter is hidden by overload#8769
Merged
henon merged 7 commits intoMudBlazor:devfrom Apr 21, 2024
Merged
CssBuilder, StyleBuilder: Fix method with optional parameter is hidden by overload#8769henon merged 7 commits intoMudBlazor:devfrom
henon merged 7 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
ScarletKuro
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8769 +/- ##
==========================================
+ Coverage 89.82% 90.12% +0.29%
==========================================
Files 412 419 +7
Lines 11878 12186 +308
Branches 2364 2400 +36
==========================================
+ Hits 10670 10983 +313
+ Misses 681 661 -20
- Partials 527 542 +15 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Improved missing xml comments and improved the wording in general, since it's basically a core part for building components. |
Member
Author
|
I think it would be interesting to add an implicit operator to not call build, what others think about it? |
Member
Author
|
Improved coverage, I'm done with this |
henon
approved these changes
Apr 21, 2024
Contributor
|
Nice, looks like a lot of work went into the xml docs. |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem with this is that if you have overloads:
And someone of them has an optional value
bool when = truethis two start to conflict with each other and code analyzers will tell you to fix it.To fix it, there is two ways:
I went for second option.
More info: https://stackoverflow.com/questions/16546831/overloaded-methods-give-method-with-optional-parameter-is-hidden-by-overload-w
Type of Changes
Checklist
dev).