MudTreeView: Move checkbox icon customization from item to treeview#8750
Merged
henon merged 1 commit intoMudBlazor:devfrom Apr 21, 2024
Merged
MudTreeView: Move checkbox icon customization from item to treeview#8750henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
breaking change
henon
added
API change
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #8750 +/- ##
==========================================
+ Coverage 89.82% 90.02% +0.19%
==========================================
Files 412 419 +7
Lines 11878 12176 +298
Branches 2364 2399 +35
==========================================
+ Hits 10670 10962 +292
+ Misses 681 669 -12
- Partials 527 545 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ScarletKuro
approved these changes
Apr 19, 2024
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
2 tasks
henon
commented
May 11, 2024
| public bool Loading { get; set; } | ||
| private string CheckedIcon => MudTreeRoot?.CheckedIcon ?? Icons.Material.Filled.CheckBox; | ||
|
|
||
| private string UncheckedIcon => MudTreeRoot?.CheckedIcon ?? Icons.Material.Filled.CheckBoxOutlineBlank; |
Contributor
Author
There was a problem hiding this comment.
This copypaste error is responsible for issue #8940
henon
added a commit
to henon/MudBlazor
that referenced
this pull request
May 11, 2024
henon
added a commit
to henon/MudBlazor
that referenced
this pull request
May 11, 2024
danielchalmers
added
regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #8661
It just doesn't make sense to be able to set different per-item checkbox icons in a tree view, so I moved the checkbox icon parameters into MudTreeView. Also discovered some minor things we overlooked in #8661
How Has This Been Tested?
existing tests
Type of Changes
Checklist
dev).