New Component: Add MudFlexBreak component for forcing flex items onto a new line#8748
Merged
henon merged 4 commits intoMudBlazor:devfrom Apr 22, 2024
Merged
New Component: Add MudFlexBreak component for forcing flex items onto a new line#8748henon merged 4 commits intoMudBlazor:devfrom
henon merged 4 commits intoMudBlazor:devfrom
Conversation
Implements MudBlazor#6712 by adding a `MudGridBreak` component that can be used in the MudGrid in order to force items onto the next line. It's very simple to add because we already use flexbox in the grid.
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8748 +/- ##
==========================================
+ Coverage 89.82% 90.08% +0.25%
==========================================
Files 412 420 +8
Lines 11878 12178 +300
Branches 2364 2396 +32
==========================================
+ Hits 10670 10971 +301
+ Misses 681 667 -14
- Partials 527 540 +13 ☔ View full report in Codecov by Sentry. |
jperson2000
approved these changes
Apr 19, 2024
Contributor
jperson2000
left a comment
jperson2000
left a comment
There was a problem hiding this comment.
It looks good to me! Nice work with nameof()
ScarletKuro
requested changes
Apr 19, 2024
Contributor
|
@danielchalmers This will even work with other flex-based components such as |
Member
|
I also forgot to mention that we probably should add xml comments to |
danielchalmers
changed the title
Member
Author
|
@ScarletKuro @henon Take a look now |
ScarletKuro
approved these changes
Apr 20, 2024
Contributor
Nice example ❤️ |
henon
added
new component
henon
changed the title
Contributor
|
Thanks! |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #6712 by adding a
MudFlexBreakcomponent that can be used in any flexbox layout, such as MudGrid or MudStack, in order to force items onto the next line, similar to<br>.It's very simple to add because we already use flexbox in the grid.
How Has This Been Tested?
visually
Type of Changes
Grid
Stack
Checklist
dev).