Skip to content

MudListItem: Replace Avatar and AvatarClass with AvatarContent#8677

Merged
henon merged 3 commits intoMudBlazor:devfrom
henon:list-avatar
Apr 14, 2024
Merged

MudListItem: Replace Avatar and AvatarClass with AvatarContent#8677
henon merged 3 commits intoMudBlazor:devfrom
henon:list-avatar

Conversation

@henon
Copy link
Contributor

@henon henon commented Apr 13, 2024 •
edited
Loading

Description

The Avatar parameter was just an icon with a circle background nothing more. It didn't live up to the expectation of an actual avatar. By removing it and making AvatarContent a renderfragment it is now much more potent at the cost of brevity in the markup which I hope isn't that big of an issue.

Before:
image

After:
image

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Apr 13, 2024
@henon henon added API change Modifies the public API surface v7 labels Apr 13, 2024
@codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (28bc599) to head (f5db387).
Report is 40 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8677      +/-   ##
==========================================
+ Coverage   89.82%   90.08%   +0.25%     
==========================================
  Files         412      418       +6     
  Lines       11878    12007     +129     
  Branches     2364     2366       +2     
==========================================
+ Hits        10670    10817     +147     
+ Misses        681      658      -23     
- Partials      527      532       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ScarletKuro
ScarletKuro approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense

@henon henon merged commit c26b2ac into MudBlazor:dev Apr 14, 2024
@henon henon mentioned this pull request Apr 14, 2024
Closed
@henon
Copy link
Contributor Author

henon commented Apr 14, 2024

Added to v7.0.0 Migration Guide #8447

@henon henon deleted the list-avatar branch April 18, 2024 19:26
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@henon @biegehydra
MudListItem: Replace Avatar and AvatarClass with AvatarContent (MudBl…
7f5606b 
…azor#8677)
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielchalmers danielchalmers danielchalmers approved these changes

@ScarletKuro ScarletKuro ScarletKuro approved these changes

+1 more reviewer

@mckaragoz mckaragoz mckaragoz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@henon @danielchalmers @ScarletKuro @mckaragoz