Skip to content

MudAvatar: Remove Obsolete Image Property#8648

Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom
Anu6is:Obsolete-Image-Property
Apr 12, 2024
Merged

MudAvatar: Remove Obsolete Image Property#8648
ScarletKuro merged 3 commits intoMudBlazor:devfrom
Anu6is:Obsolete-Image-Property

Conversation

@Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Apr 11, 2024

Description

Remove obsolete property, Image, from MudAvatar component

How Has This Been Tested?

Reviewed all doc pages/examples where changes were made

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Apr 11, 2024
@codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (28bc599) to head (e92a5b3).
Report is 28 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8648      +/-   ##
==========================================
+ Coverage   89.82%   89.89%   +0.06%     
==========================================
  Files         412      414       +2     
  Lines       11878    11909      +31     
  Branches     2364     2361       -3     
==========================================
+ Hits        10670    10705      +35     
+ Misses        681      672       -9     
- Partials      527      532       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Member

Nice. Unrelated but someone needs to fix this ugly avatar background on the announcements

image

@Anu6is
Copy link
Contributor Author

Anu6is commented Apr 11, 2024

Nice. Unrelated but someone needs to fix this ugly avatar background on the announcements

lol yes, I saw that while testing

@ScarletKuro
Copy link
Member

Added to v7.0.0 Migration Guide #8447 under "Others"

@ScarletKuro ScarletKuro merged commit 6ba041c into MudBlazor:dev Apr 12, 2024
@Anu6is Anu6is deleted the Obsolete-Image-Property branch April 12, 2024 12:39
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants