Skip to content

Alert: Remove AlertTextPosition#8637

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:AlertTextPosition_remove
Apr 12, 2024
Merged

Alert: Remove AlertTextPosition#8637
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:AlertTextPosition_remove

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 11, 2024

Description

After this PR #8532 it's not used anymore

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@ScarletKuro ScarletKuro requested a review from henon April 11, 2024 00:35
@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Apr 11, 2024
@ScarletKuro ScarletKuro added API change Modifies the public API surface v7 and removed PR: needs review labels Apr 11, 2024
@danielchalmers
Copy link
Member

danielchalmers commented Apr 11, 2024 •
edited
Loading

Ha got there just before me 😀

I was going to check the whole codebase for unused code. Do you know if there's any more?

@codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (28bc599) to head (f4fab9c).
Report is 19 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8637      +/-   ##
==========================================
+ Coverage   89.82%   89.88%   +0.05%     
==========================================
  Files         412      414       +2     
  Lines       11878    11913      +35     
  Branches     2364     2364              
==========================================
+ Hits        10670    10708      +38     
+ Misses        681      675       -6     
- Partials      527      530       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Apr 11, 2024
Merged
Closed
@ScarletKuro
Copy link
Member Author

ScarletKuro commented Apr 12, 2024

Added to v7.0.0 Migration Guide #8447 under "Others"

@ScarletKuro ScarletKuro merged commit 6218eea into MudBlazor:dev Apr 12, 2024
@ScarletKuro ScarletKuro deleted the AlertTextPosition_remove branch April 12, 2024 11:34
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@ScarletKuro @biegehydra
Alert: Remove AlertTextPosition (MudBlazor#8637)
0354097
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScarletKuro @danielchalmers