Skip to content

MudBaseInput: Add nullable annotation.#8635

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:MudBaseInput_nullable
Apr 10, 2024
Merged

MudBaseInput: Add nullable annotation.#8635
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ScarletKuro:MudBaseInput_nullable

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 10, 2024

Description

Part of this issue #6535

How Has This Been Tested?

No tests required.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@ScarletKuro ScarletKuro mentioned this pull request Apr 10, 2024
Open
94 tasks
@ScarletKuro ScarletKuro added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library and removed PR: needs review labels Apr 10, 2024
@codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.85%. Comparing base (28bc599) to head (2511635).
Report is 18 commits behind head on dev.

Files Patch % Lines
src/MudBlazor/Base/MudBaseInput.cs 68.75% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8635      +/-   ##
==========================================
+ Coverage   89.82%   89.85%   +0.02%     
==========================================
  Files         412      414       +2     
  Lines       11878    11913      +35     
  Branches     2364     2364              
==========================================
+ Hits        10670    10705      +35     
+ Misses        681      677       -4     
- Partials      527      531       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit d75dd57 into MudBlazor:dev Apr 10, 2024
@ScarletKuro ScarletKuro deleted the MudBaseInput_nullable branch April 10, 2024 23:16
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@ScarletKuro @biegehydra
MudBaseInput: Add nullable annotation. (MudBlazor#8635)
fff050f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScarletKuro