Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (f70bb9e) to head (bda57e9).
Report is 11 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #8598      +/-   ##
==========================================
+ Coverage   89.78%   89.89%   +0.11%     
==========================================
  Files         411      412       +1     
  Lines       11840    11881      +41     
  Branches     2363     2362       -1     
==========================================
+ Hits        10630    10680      +50     
+ Misses        682      675       -7     
+ Partials      528      526       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

So clickable chips can not be selected but readonly chips can? I see a ripple in the video where you selected text on the chip. Should we also disable the ripple if the chip is not clickable?

So clickable chips can not be selected but readonly chips can? I see a ripple in the video where you selected text on the chip. Should we also disable the ripple if the chip is not clickable?

I would probably make it work like MUI but I'll leave those decisions to someone else because I don't use the chips enough to have an opinion. I just copied the other PRs.

OK, in MUI clickable chips are not selectable but do hover and ripple. Non-clickable are selectable but don't hover and have no ripple. If it is like that now this can be merged.

OK, in MUI clickable chips are not selectable but do hover and ripple. Non-clickable are selectable but don't hover and have no ripple. If it is like that now this can be merged.

I can make it like that if that's the consensus (I agree)

Yes, let's do it like that. No need to make it more complicated if we already agree ;)

@henon Done. Please checkout the branch and see if it's what you expect

Thanks @danielchalmers