FYI @BieleckiLtd

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (d6a1268) to head (61cf6d0).
Report is 4 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #8593      +/-   ##
==========================================
- Coverage   89.78%   89.78%   -0.01%     
==========================================
  Files         411      411              
  Lines       11821    11840      +19     
  Branches     2362     2363       +1     
==========================================
+ Hits        10613    10630      +17     
- Misses        681      682       +1     
- Partials      527      528       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We already have Outlined in another component, that's why I chose it.

I didn't want Outline because that is an enum member which I don't want to confuse with this parameter. Border would work, but my gut says no, I can't really argument it though.

I didn't want Outline because that is an enum member which I don't want to confuse with this parameter. Border would work, but my gut says no, I can't really argument it though.

It's a border so it shouldn't be referred to as an outline:

Border works in the same way DropShadow does. I think both could be implicitly converted to enums or numbers in the future if desired.

The Outlined property of MudPaper and MudCard

.mud-paper-outlined {
  border: 1px solid var(--mud-palette-lines-default);
}

I think we should go with Outlined in ExpansionPanel as well for consistency

The Outlined property of MudPaper and MudCard

.mud-paper-outlined {
  border: 1px solid var(--mud-palette-lines-default);
}

I think we should go with Outlined in ExpansionPanel as well for consistency

There's a real difference between border and outline in CSS so this is all misleading

I get your point, and for you as a CSS pro it may make a big difference. But the user of the Card or ExpansionPanel doesn't care about such subtle CSS differences?

I get your point, and for you as a CSS pro it may make a big difference. But the user of the Card or ExpansionPanel doesn't care about such subtle CSS differences?

CSS pro is generous 😄

Realistically it'll be fine either way, but I feel like if you're already making breaking changes, why not be accurate? It's a subtle thing but is firmly named wrong now.

I think MUI uses borders and not outlines too

We are already renaming so much. I don't want to rename more than is necessary. Next we'd have to rename the Variant.Outline too for consistency and I really don't think that it is necessary to take that step.

@danielchalmers shall we do a team vote on discord or do you accept my arguments?

@danielchalmers shall we do a team vote on discord or do you accept my arguments?

I disagree on both counts. The name should be Border/Borders/Bordered for this because it appropriately uses a border, and Variant.Outline should be changed to use a CSS outline because It doesn't make sense that the outlined button is bigger IMO.

I don't want to simply dismiss @danielchalmers arguments just because I disagree. When we have a disagreement like this we usually resolve it by a simple majority vote in the team.

Choice 1) Rename MudExpansionPanels.DisableBorders to MudExpansionPanels.Outlined and don't touch Outlined in MudCard, MudPaper and in Variant.Outline.

Choice 2) Rename MudExpansionPanels.DisableBorders to MudExpansionPanels.Border and rename Outlined in MudCard, MudPaper and also in Variant.Outline to Border

@MudBlazor/contribution-team @MudBlazor/core-team Please post your opinions so we can resolve this deadlock.

Choice 3) Rename MudExpansionPanels.DisableBorders to MudExpansionPanels.Outlined and change MudExpansionPanels, MudCard, MudPaper and also Button with Variant.Outline to use CSS outline instead of CSS border

Choice 1 sounds like the best option to me.

I agree with @henon here. Sure there is also outlined in CSS but it was never meant to reflect the css property.

I think renaming it to Outlined is the best option to streamline it with the rest of the library.

Makes sense 👍
Not super important either way