Skip to content

Various Components: Rename DisableUnderLine to Underline#8591

Merged
henon merged 3 commits intoMudBlazor:devfrom
henon:underline
Apr 12, 2024
Merged

Various Components: Rename DisableUnderLine to Underline#8591
henon merged 3 commits intoMudBlazor:devfrom
henon:underline

Conversation

@henon
Copy link
Contributor

@henon henon commented Apr 6, 2024

Description

We want to move from DisableSomething to just Something or EnableSomething depending on the property. This PR tackles only DisableUnderLine and renames it to just UnderLine. Of course default value and all invocations have been inverted.

See #6131

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Apr 6, 2024
@henon henon added API change Modifies the public API surface v7 labels Apr 6, 2024
@henon
Copy link
Contributor Author

henon commented Apr 6, 2024

FYI @BieleckiLtd

@codecov
Copy link

codecov bot commented Apr 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (28bc599) to head (9895301).
Report is 31 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8591      +/-   ##
==========================================
+ Coverage   89.82%   90.03%   +0.20%     
==========================================
  Files         412      418       +6     
  Lines       11878    12031     +153     
  Branches     2364     2371       +7     
==========================================
+ Hits        10670    10832     +162     
+ Misses        681      666      -15     
- Partials      527      533       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Member

danielchalmers commented Apr 6, 2024

UnderLine should be Underline if you're breaking it anyway

@henon henon marked this pull request as draft April 8, 2024 08:27
@henon henon changed the title Various Components: Rename DisableUnderLine to UnderLine Various Components: Rename DisableUnderLine to Underline Apr 12, 2024
@henon henon marked this pull request as ready for review April 12, 2024 14:21
@henon henon merged commit 3629e89 into MudBlazor:dev Apr 12, 2024
@henon henon mentioned this pull request Apr 12, 2024
Closed
@henon henon deleted the underline branch April 18, 2024 19:25
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@henon @biegehydra
Various Components: Rename DisableUnderLine to Underline (MudBlazor#8591
535eb76 
)
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro Awaiting requested review from ScarletKuro

@danielchalmers danielchalmers Awaiting requested review from danielchalmers

Assignees

No one assigned

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henon @danielchalmers @ScarletKuro