MudButton: fix focus style button when open dialog#8575
MudButton: fix focus style button when open dialog#8575Garderoben merged 1 commit intoMudBlazor:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8575 +/- ##
==========================================
+ Coverage 89.75% 89.77% +0.02%
==========================================
Files 411 411
Lines 11817 11817
Branches 2362 2362
==========================================
+ Hits 10606 10609 +3
+ Misses 683 681 -2
+ Partials 528 527 -1 ☔ View full report in Codecov by Sentry. |
|
Just fyi your sound is on in the clips |
|
lol |
|
Nice work, again. Thanks for looking into this. I do wonder why |
|
I want @Garderoben to double check this to be sure. |
|
When using the :focus-visible pseudo-class, the applied style will only be visible if the focused element is via keyboard, such as when pressing the "Tab" key to toggle between buttons. |
|
@LiZzeira Do you think we should be looking at any of the other components that use |
|
@danielchalmers I'll conduct some tests on these additional components, and if needed, I'll update and push a new PR |
Fixes a regression of MudBlazor#8256 caused by MudBlazor#8575 Not perfect but probably the best with the tools we have.
Description
The style file for the MudButton components has been updated to include the :focus and :focus-visible pseudo-classes, applying them to the respective buttons.
How Has This Been Tested?
I made a style modification to ensure that the focus on the button is correctly applied when the dialog opens.
This modification addresses several issues, such as:
#4283
#8451
Types of changes
Before:
Dialog.-.MudBlazor.-.Google.Chrome.2024-04-04.22-42-50.mp4
After:
https://github.com/MudBlazor/MudBlazor/assets/79289665/e0609b70-9899-48c0-90de-61f2d585b468
https://github.com/MudBlazor/MudBlazor/assets/79289665/6877c9d1-dd11-496f-bdbf-9cd41498c8b5
https://github.com/MudBlazor/MudBlazor/assets/79289665/07386ced-3695-427b-bacd-10e03e15cabd
Checklist:
dev).