Several Components: Remove obsolete API#8564
Merged
henon merged 2 commits intoMudBlazor:devfrom Apr 4, 2024
Merged
Conversation
github-actions
bot
added
breaking change
Member
Author
|
Let me know of any more obsoletes to remove in the next PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8564 +/- ##
==========================================
+ Coverage 89.52% 89.75% +0.22%
==========================================
Files 411 411
Lines 11848 11818 -30
Branches 2362 2362
==========================================
Hits 10607 10607
+ Misses 713 683 -30
Partials 528 528 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
Apr 4, 2024
Closed
henon
added
API change
Contributor
|
Thanks! |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@ScarletKuro gave me this list:
MudBooleanInput.cs, DialogService.cs, IFormComponent.cs, ScrollManager.cs, MudAvatar.razor.cs, MudFormComponent.cs, MudDataGrid.razor.cs
This PR takes care of most of them and does some light code cleanup as well since those files will be conflicted anyway.
MudAvatar and MudDataGrid will come after this and #8562 have been merged.
#8472 will help with future removals + cleanups like this
How Has This Been Tested?
Types of changes
Checklist:
dev).