DataGrid : Fix sorting when there is Header row (#7645)#8504
Merged
henon merged 1 commit intoMudBlazor:devfrom Mar 28, 2024
Merged
DataGrid : Fix sorting when there is Header row (#7645)#8504henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8504 +/- ##
==========================================
+ Coverage 89.03% 89.08% +0.04%
==========================================
Files 411 411
Lines 12175 12173 -2
Branches 2431 2431
==========================================
+ Hits 10840 10844 +4
+ Misses 799 795 -4
+ Partials 536 534 -2 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
Mar 27, 2024
Member
|
@henon I suggest to merge it without @tjscience review as it just fixed a null exception. |
Contributor
|
Thanks @timlunev |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
…Blazor#8504) Co-authored-by: Tymur Lunov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MudDataGrid has an issue with the HeaderCell component when the Header is added and there is no Column on a sort.
This PR fixes #7645
How Has This Been Tested?
A new DataGrid unit test was added to verify if sorting does not throw NullReferenceException and if sorting is still working as expected.
Types of changes
Checklist:
dev).