Skip to content

MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken to SearchFunc#8490

Merged
henon merged 16 commits intoMudBlazor:devfrom
jperson2000:feature/mudautocomplete-searchfunc-cancellationtoken
Mar 27, 2024
Merged

MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken to SearchFunc#8490
henon merged 16 commits intoMudBlazor:devfrom
jperson2000:feature/mudautocomplete-searchfunc-cancellationtoken

Conversation

@jperson2000
Copy link
Contributor

@jperson2000 jperson2000 commented Mar 26, 2024 •
edited
Loading

This breaking change removes the SearchFuncWithCancel method and moves the CancellationToken functionality to the SearchFunc method.

Description

Recent changes to the MudTable ServerData method (PR 8407) led to a desire to use the same single-method pattern for other cancelable methods. This update:

  • Removes the SearchFuncWithCancel method
  • Moves the CancellationToken parameter to the SearchFunc method
  • Updates all tests and examples to include the new CancellationToken parameter.

How Has This Been Tested?

Existing tests for MudAutocomplete were modified to include the CancellationToken parameter.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Notes for Reviewers

This should probably get a v7 tag and be released with similar breaking changes to MudTable in the works for #8447

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Mar 26, 2024
@jperson2000 jperson2000 mentioned this pull request Mar 26, 2024
Merged
6 tasks
@ScarletKuro ScarletKuro requested a review from henon March 27, 2024 10:55
@henon henon changed the title MudAutocomplete: Removed SearchFuncWithCancel, Added CancellationToken to SearchFunc MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken to SearchFunc Mar 27, 2024
@henon henon added API change Modifies the public API surface v7 and removed PR: needs review labels Mar 27, 2024
@henon henon mentioned this pull request Mar 27, 2024
Closed
@henon
Copy link
Contributor

henon commented Mar 27, 2024

There are conflicts. Please merge dev to resolve them.

Added to v7.0.0 Migration Guide #8447

@ScarletKuro
Copy link
Member

ScarletKuro commented Mar 27, 2024

LGTM, just need to rebase and fix conflicts like henon said.

Jon Person added 9 commits March 27, 2024 09:04
MudAutocomplete: Removed SearchFuncWithCancel and added CancellationT…
4464f33 
…oken to SearchFunc
Merge branch 'feature/mudautocomplete-searchfunc-cancellationtoken' of …
8063009 
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
MudAutocomplete: Removed SearchFuncWithCancel and added CancellationT…
979dfad 
…oken to SearchFunc
Merge branch 'feature/mudautocomplete-searchfunc-cancellationtoken' of …
78fa232 
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
MudAutocomplete: Removed SearchFuncWithCancel and added CancellationT…
ef5c591 
…oken to SearchFunc
Merge branch 'feature/mudautocomplete-searchfunc-cancellationtoken' of …
32f3290 
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
MudAutocomplete: Removed SearchFuncWithCancel and added CancellationT…
2fdb23a 
…oken to SearchFunc
MudAutocomplete: Rebased to dev
7b8c3f5
MudAutocomplete: Re-added CancellationToken to search methods after r…
5d24f5b 
…ebasing
@jperson2000
Copy link
Contributor Author

jperson2000 commented Mar 27, 2024

Alright, thanks again for all the reviews and feedback! I've rebased onto dev and added 1 commit to re-implement the new token parameter in MudBlazor.Docs\Shared\AppBar.razor.

@henon
Copy link
Contributor

henon commented Mar 27, 2024

Next time please just merge dev, somehow rebasing with Visual Studio messes up the PR. You are done, however, so it doesn't really matter. Just so you know.

@henon henon merged commit ef34068 into MudBlazor:dev Mar 27, 2024
@henon
Copy link
Contributor

henon commented Mar 27, 2024

And thanks for the contribution @jperson2000 !

@jperson2000 jperson2000 deleted the feature/mudautocomplete-searchfunc-cancellationtoken branch April 18, 2024 23:16
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@jperson2000 @biegehydra
MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken t…
5ff2b9a 
…o SearchFunc (MudBlazor#8490)

Co-authored-by: Jon Person <[email protected]>
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon henon approved these changes

Assignees

No one assigned

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jperson2000 @henon @ScarletKuro @danielchalmers @ArieGato