MudBaseInput: Remove obsoleted KeyPress related APIs#8476
Merged
henon merged 2 commits intoMudBlazor:devfrom Mar 27, 2024
Merged
MudBaseInput: Remove obsoleted KeyPress related APIs#8476henon merged 2 commits intoMudBlazor:devfrom
henon merged 2 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
breaking change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8476 +/- ##
==========================================
+ Coverage 88.76% 89.16% +0.39%
==========================================
Files 416 411 -5
Lines 12359 12162 -197
Branches 2458 2431 -27
==========================================
- Hits 10971 10844 -127
+ Misses 855 784 -71
- Partials 533 534 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
LGTM |
ScarletKuro
reviewed
Mar 27, 2024
| @onpaste="@OnPaste" | ||
| value="@_internalText" | ||
| maxlength="@MaxLength" | ||
| @onkeydown:preventDefault="@KeyDownPreventDefault" |
Member
There was a problem hiding this comment.
I know it's not related to the PR, but i guess we can fix the formatting in right away, the onkeydown:preventDefault has also the same problem
Member
Author
There was a problem hiding this comment.
Sorry, not sure what you mean by this. The number of spaces before each line?
Member
Author
There was a problem hiding this comment.
gotcha. tabs are now spaces
Member
|
Otherwise LGTM |
ScarletKuro
approved these changes
Mar 27, 2024
Closed
henon
added
API change
Contributor
|
Added to v7.0.0 Migration Guide #8447 |
6 tasks
2 tasks
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Types of changes
Checklist:
dev).