Skip to content

EnumExtensions: Remove ToDescriptionString#8474

Merged
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:enumextensions_remove
Mar 26, 2024
Merged

EnumExtensions: Remove ToDescriptionString#8474
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:enumextensions_remove

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Mar 25, 2024

Description

Remove public ToDescriptionString enum extension.
We are using source-generator and we do not need this anymore.
People that used it in their own projects should add their own extension.
Also, I once saw a project that reference 3rd-party libraries, and there was 4 ToDescription extensions coming from different libraries, so it's pretty common extension and we don't need to add another one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Mar 25, 2024
@ScarletKuro ScarletKuro added the API change Modifies the public API surface label Mar 25, 2024
@ScarletKuro ScarletKuro requested a review from henon March 26, 2024 10:46
@henon henon merged commit 91d5edf into MudBlazor:dev Mar 26, 2024
@henon henon mentioned this pull request Mar 26, 2024
@ScarletKuro ScarletKuro deleted the enumextensions_remove branch March 26, 2024 12:39
@henon
Copy link
Contributor

henon commented Mar 26, 2024

Added to
v7.0.0 Migration Guide #8447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants