Skip to content

Various components: Remove obsolete Link in favor of Href#8471

Merged
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:obsolete-link-href
Mar 26, 2024
Merged

Various components: Remove obsolete Link in favor of Href#8471
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:obsolete-link-href

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Mar 25, 2024

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Mar 25, 2024
@codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (9bb4af1) to head (4a2dbda).
Report is 6 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8471      +/-   ##
==========================================
+ Coverage   88.76%   88.85%   +0.08%     
==========================================
  Files         416      416              
  Lines       12359    12303      -56     
  Branches     2458     2447      -11     
==========================================
- Hits        10971    10932      -39     
+ Misses        855      835      -20     
- Partials      533      536       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ScarletKuro
ScarletKuro approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@ScarletKuro ScarletKuro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Btw, why are we not using something like <see cref="Href"/> etc? Is it not supported by docs?

@danielchalmers
Copy link
Member Author

danielchalmers commented Mar 25, 2024

LGTM.
Btw, why are we not using something like <see cref="Href"/> etc? Is it not supported by docs?

It's not

@ScarletKuro ScarletKuro requested a review from henon March 26, 2024 10:48
@henon henon merged commit 5dd3601 into MudBlazor:dev Mar 26, 2024
@henon henon mentioned this pull request Mar 26, 2024
Closed
@henon
Copy link
Contributor

henon commented Mar 26, 2024

Added to v7.0.0 Migration Guide #8447

@danielchalmers danielchalmers deleted the obsolete-link-href branch April 4, 2024 23:47
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@danielchalmers @biegehydra
Various components: Remove obsolete Link in favor of Href (MudBlazor#…
7ce4e69 
…8471)
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

breaking change This change will require consumer code updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielchalmers @henon @ScarletKuro