/home/runner/work/MudBlazor/MudBlazor/src/MudBlazor/Components/Dialog/DialogOptions.cs(26,22): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/runner/work/MudBlazor/MudBlazor/src/MudBlazor/MudBlazor.csproj::TargetFramework=net7.0]

    public class DialogOptions
    {
        public DialogPosition? Position { get; set; }

        public MaxWidth? MaxWidth { get; set; }

        public bool? DisableBackdropClick { get; set; }
        public bool? CloseOnEscapeKey { get; set; }
        public bool? NoHeader { get; set; }
        public bool? CloseButton { get; set; }
        public bool? FullScreen { get; set; }
        public bool? FullWidth { get; set; }
        public string? ClassBackground { get; set; }
    }

I don't understand, you don't accept the possibility of a null on a string? The parameter may not be present, so it should be null, it is optional.

That string should be nullable by default because it's not in a '#nullable' annotations context. Try dropping the ?.

@danielchalmers I have enabled nullable for these two files and fixed the errors with null missing. We should support null, even Microsoft recommends that we have nullable enabled for the entire project.

Please see #6535 if you're interested in helping in this area

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (61e8a76) to head (2e8fa79).

@@           Coverage Diff           @@
##              dev    #8458   +/-   ##
=======================================
  Coverage   88.84%   88.85%           
=======================================
  Files         416      416           
  Lines       12358    12359    +1     
  Branches     2458     2458           
=======================================
+ Hits        10980    10981    +1     
  Misses        845      845           
  Partials      533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Please see #6535 if you're interested in helping in this area

In a few days I will have a little free time so I can help a little.

Please see #6535 if you're interested in helping in this area

In a few days I will have a little free time so I can help a little.

I know that'll be very appreciated!

Please rename it to BackgroundClass in DialogOptions.

@ArieGato will change the property name in dialog provider in his breaking-change PR to BackgroundClass as well, then we will have consistency.

@henon
Changing the name will cause problems when updating systems that already exist. I suggest you add a new name but keep the old one too with ObsoleteAttribute.
Then, in some time, retire the old name completely.
https://learn.microsoft.com/pl-pl/dotnet/api/system.obsoleteattribute?view=net-8.0

I know we do this all the time. But the next release will be v7.0.0 where we finally after waiting for years remove all obsolete properties and make breaking changes. This will be only one in a dozen breaking changes and there will be a migration guide: #8447

In any case, you can rename the property you added without a breaking change, so please do so.

@henon Ok, I understand. Done

I guess this is breaking change
ClassBackground -> BackgroundClass since public API is changed?

Added to the v7.0.0 Migration Guide
#8447

Hi all, I can see the property in the MudDialogProvider component (7.0), that's great. But is it really implemented?
I'm asking because it has no effect for what I could test with 2 projects. Neither in a ShowDialog nor a Dialog<>.ShowAsync

Thanks