Skip to content

Palette: Make abstract & Rename to PaletteLight in MudTheme and make type PaletteLight#8453

Merged
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:palette
Mar 28, 2024
Merged

Palette: Make abstract & Rename to PaletteLight in MudTheme and make type PaletteLight#8453
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:palette

Conversation

@danielchalmers
Copy link
Member

Description

#6519 (comment)

Migration guide:

PaletteLight

  • Palette has been made abstract.
  • MudTheme.Palette is now PaletteLight and is of type PaletteLight to match PaletteDark.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers requested a review from henon March 25, 2024 00:20
@github-actions github-actions bot added breaking change This change will require consumer code updates PR: needs review labels Mar 25, 2024
@danielchalmers danielchalmers changed the title Make Palette abstract & Rename MudTheme.Palette to PaletteLight and make it of type PaletteLight Palette: Make abstract & Rename to PaletteLight in MudTheme and make type PaletteLight Mar 25, 2024
@danielchalmers
Copy link
Member Author

Not sure if it will conflict with plans for new MudTheme #3669 (comment)

@codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (9bb4af1) to head (fa5d6c7).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8453      +/-   ##
==========================================
- Coverage   88.76%   88.72%   -0.05%     
==========================================
  Files         416      416              
  Lines       12359    12359              
  Branches     2458     2458              
==========================================
- Hits        10971    10966       -5     
- Misses        855      858       +3     
- Partials      533      535       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScarletKuro ScarletKuro added the API change Modifies the public API surface label Mar 25, 2024
@henon henon mentioned this pull request Mar 28, 2024
@henon henon added v7 and removed PR: needs review labels Mar 28, 2024
@henon henon merged commit 68edc91 into MudBlazor:dev Mar 28, 2024
@henon
Copy link
Contributor

henon commented Mar 28, 2024

Thanks!

Added to v7.0.0 Migration Guide #8447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants