Skip to content

MudDialog: Fix some params not passed when inline#8424

Merged
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:dialog-show-params
Mar 23, 2024
Merged

MudDialog: Fix some params not passed when inline#8424
henon merged 1 commit intoMudBlazor:devfrom
danielchalmers:dialog-show-params

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Mar 23, 2024

Description

Fixes #4719
Fixes #6145

Some parameters were not being set which was notably causing the OnBackdropClick callback to not be fired after the dialog was shown by IsVisible.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Mar 23, 2024
@danielchalmers
Copy link
Member Author

👀 #6174 may optimize the IsVisible setter

@codecov
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (222b8bb) to head (f2a2d4f).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8424      +/-   ##
==========================================
+ Coverage   88.80%   88.89%   +0.08%     
==========================================
  Files         414      414              
  Lines       12294    12297       +3     
  Branches     2455     2455              
==========================================
+ Hits        10918    10931      +13     
+ Misses        844      836       -8     
+ Partials      532      530       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Mar 23, 2024

LGTM, thanks for looking into it.
Wish people that reported the issue would make a PR since the fix is really easy.

@henon henon merged commit b21c7fa into MudBlazor:dev Mar 23, 2024
@henon
Copy link
Contributor

henon commented Mar 23, 2024

Thanks @danielchalmers

@ScarletKuro
Copy link
Member

👀 #6174 may optimize the IsVisible setter

Would be nice, it should be really easy with ParameterState.

@BieleckiLtd
Copy link
Contributor

LGTM, thanks for looking into it.

Wish people that reported the issue would make a PR since the fix is really easy.

I’ve reported a couple more issues that I could work on, but there are instructions not to unless agreed upon. Perhaps this information should be removed?

@danielchalmers
Copy link
Member Author

danielchalmers commented Mar 23, 2024

LGTM, thanks for looking into it.
Wish people that reported the issue would make a PR since the fix is really easy.

I’ve reported a couple more issues that I could work on, but there are instructions not to unless agreed upon. Perhaps this information should be removed?

@BieleckiLtd that message was clarified recently in #8321 due to what you're expressing

I think PRs are very encouraged. It was just worded wrong before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDialog: OnBackdropClick not working MudDialog not solving the problem when an argument is passed @bind-IsVisible

4 participants