Skip to content

MudLink: Fix exception doesn't flow to ErrorBoundary.#8375

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:MudLink_fix
Mar 15, 2024
Merged

MudLink: Fix exception doesn't flow to ErrorBoundary.#8375
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:MudLink_fix

Conversation

@ScarletKuro
Copy link
Member

Description

Follows: #8369
See: #8365 (comment) and dotnet/aspnetcore#54543
PR that introduced regression: #8281

How Has This Been Tested?

New unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Mar 15, 2024
@codecov
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (b700d96) to head (1205789).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8375      +/-   ##
==========================================
- Coverage   88.90%   88.89%   -0.02%     
==========================================
  Files         407      407              
  Lines       12225    12226       +1     
  Branches     2441     2441              
==========================================
- Hits        10869    10868       -1     
- Misses        828      829       +1     
- Partials      528      529       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member Author

@danielchalmers @henon I will do one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant