MudDataGridPager: Add ShowNavigation and ShowPageNumber#8363
MudDataGridPager: Add ShowNavigation and ShowPageNumber#8363henon merged 6 commits intoMudBlazor:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8363 +/- ##
==========================================
+ Coverage 89.82% 89.86% +0.03%
==========================================
Files 412 414 +2
Lines 11878 11913 +35
Branches 2364 2364
==========================================
+ Hits 10670 10706 +36
+ Misses 681 676 -5
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. |
|
@mckaragoz In the title of the PR you wrote |
Can someone explain my why and what it the benefit of using |
MudDataGridPager can only navigate to previous or next page. But with MudPagination user can go to 5th page from 1st page directly. If a datagrid has 10 pages and you want to go 5th one, need to click next page button 4 times, which is really unnecessary. |
tjscience
left a comment
There was a problem hiding this comment.
This looks good, thanks!
|
A small bUnit test would be nice so we could safely merge it and not worry that it breaks in future for some reason. |
Well how can i test this visual? |
|
The only way is to check that the appropriate classes are applied or not applied. Should be a very simple test. |
|
Any update on this?
And yes, this what I basically want. |
|
Added test here. |
|
Look at #8594, we are doing away with negative properties. So please rename to |
|
@henon should be done now. |
DataGridPager doesn't have
HideNavigationandHidePageNumberparameters which TablePager has. This PR added these two parameters.Without these parameters, it's not possible to work with DataGridPager's page size options with MudPagination.
Description
How Has This Been Tested?
Types of changes
Checklist:
dev).