TreeView: Fix the ParameterView instance has expired.#8361
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Mar 14, 2024
Merged
TreeView: Fix the ParameterView instance has expired.#8361ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Conversation
…e it has expired.
github-actions
bot
added
bug
94 tasks
ScarletKuro
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8361 +/- ##
=======================================
Coverage 88.72% 88.72%
=======================================
Files 407 407
Lines 12169 12173 +4
Branches 2427 2428 +1
=======================================
+ Hits 10797 10801 +4
Misses 848 848
Partials 524 524 ☔ View full report in Codecov by Sentry. |
mikes-gh
reviewed
Mar 14, 2024
| selected != Activated && MudTreeRoot is not null) | ||
| // See https://github.com/MudBlazor/MudBlazor/issues/8360#issuecomment-1996168491 | ||
| var previousActivatedValue = Activated; | ||
| var activatedChanged = parameters.HasParameterChanged(nameof(Activated), Activated, out var activated);//parameters.TryGetValue(nameof(Activated), out bool activated) && activated != Activated; |
2 tasks
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
…e it has expired. (MudBlazor#8361)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #8360
Regression was added in: #7810
Also finished the nullable annotation, I didn't pay attention that in PR the annotation was started, but not finished.
I used kinda a workaround to have the same logic , ideally
ParameterStateshould be used, but honestly the logic is cumbersome and needs hours of debugging, I do not have the time for it for now. I left comments in code that redirects to this explanation #8360 (comment)How Has This Been Tested?
Existing unit tests that luckily covers all this logic
Types of changes
Checklist:
dev).