Skip to content

MudDataGrid: Respect indeterminate state in select-all checkboxes#8317

Merged
ScarletKuro merged 5 commits intoMudBlazor:devfrom
Qwertyluk:feature/datagrid-selectallcheckboxes-indeterminatestate
Apr 3, 2024
Merged

MudDataGrid: Respect indeterminate state in select-all checkboxes#8317
ScarletKuro merged 5 commits intoMudBlazor:devfrom
Qwertyluk:feature/datagrid-selectallcheckboxes-indeterminatestate

Conversation

@Qwertyluk
Copy link
Contributor

@Qwertyluk Qwertyluk commented Mar 8, 2024

Description

Resolves #6553

How Has This Been Tested?

Added a unit test to ensure that a state (including indeterminate state) of select-all checkboxes change correctly based on the number of selected items in the data grid.
Also conducted manual testing of the changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

image

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Mar 8, 2024
@codecov
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (0dcc84c) to head (9161807).

Files Patch % Lines
src/MudBlazor/Components/DataGrid/HeaderContext.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           dev    #8317       +/-   ##
========================================
+ Coverage     0   89.50%   +89.50%     
========================================
  Files        0      411      +411     
  Lines        0    11848    +11848     
  Branches     0     2362     +2362     
========================================
+ Hits         0    10604    +10604     
- Misses       0      715      +715     
- Partials     0      529      +529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from tjscience March 8, 2024 16:49
Copy link
Contributor

@tjscience tjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Appreciate it, @Qwertyluk!

@ScarletKuro ScarletKuro added breaking change This change will require consumer code updates API change Modifies the public API surface labels Apr 3, 2024
@ScarletKuro
Copy link
Member

Added to v7.0.0 Migration Guide #8447
since this PR changed public api type from bool to bool?.

@ScarletKuro ScarletKuro merged commit e6741bb into MudBlazor:dev Apr 3, 2024
@ScarletKuro
Copy link
Member

@Qwertyluk thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDataGrid: Select-all checkbox doesn't respect indeterminate state

3 participants