Localization: Extend AbstractLocalizationInterceptor to be less specific.#8306
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Mar 7, 2024
Merged
Localization: Extend AbstractLocalizationInterceptor to be less specific.#8306ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8306 +/- ##
==========================================
- Coverage 88.65% 88.61% -0.04%
==========================================
Files 407 407
Lines 12167 12169 +2
Branches 2430 2430
==========================================
- Hits 10787 10784 -3
- Misses 852 855 +3
- Partials 528 530 +2 ☔ View full report in Codecov by Sentry. |
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Mar 13, 2024
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Mar 13, 2024
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Mar 13, 2024
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After merging this #7389 and going to sleep
I thought that I need to add additional constructor overload to
AbstractLocalizationInterceptorotherwise it would be too specific - creating theResourceManagerStringLocalizerFactoryfor ourLanguageResource. But what if they need other resource or some additional options, then this abstraction should have been namaed differently and be specific to ResX, this overload makes things better.How Has This Been Tested?
Existing unit tests should cover it.
Types of changes
Checklist:
dev).