Skip to content

MudTextField: Remove phantom scrollbars when auto grow is enabled and height is uncapped#8235

Merged
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:auto-grow-phantom-scroll
Feb 25, 2024
Merged

MudTextField: Remove phantom scrollbars when auto grow is enabled and height is uncapped#8235
henon merged 2 commits intoMudBlazor:devfrom
danielchalmers:auto-grow-phantom-scroll

Conversation

@danielchalmers
Copy link
Member

Description

Sometimes, and admittedly I couldn't figure out why, phantom scroll bars would appear with certain text. This PR removes the scrollbars when the auto grow height is uncapped so it's not a problem.

Wish I knew why it was happening in the first place.

Video2.mp4

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 25, 2024
@danielchalmers danielchalmers changed the title Remove phantom scrollbars when auto grow is enabled and max height is uncapped MudTextField: Remove phantom scrollbars when auto grow is enabled and height is uncapped Feb 25, 2024
@ScarletKuro ScarletKuro requested a review from henon February 25, 2024 12:06
@henon henon merged commit 061a7b0 into MudBlazor:dev Feb 25, 2024
@henon
Copy link
Contributor

henon commented Feb 25, 2024

Thanks @danielchalmers !

danielchalmers added a commit to danielchalmers/JournalApp that referenced this pull request Mar 5, 2024
Notably
- May allow us to fix scroll jumping on navigation MudBlazor/MudBlazor#8203
- Removes phantom scrollbars MudBlazor/MudBlazor#8235
- Reverts sticky hover button fix #8247 until future fix MudBlazor/MudBlazor#8256
danielchalmers added a commit to danielchalmers/JournalApp that referenced this pull request Mar 7, 2024
Notably
- May allow us to fix scroll jumping on navigation MudBlazor/MudBlazor#8203
- Removes phantom scrollbars MudBlazor/MudBlazor#8235
- Reverts sticky hover button fix #8247 until future fix MudBlazor/MudBlazor#8256
@danielchalmers danielchalmers deleted the auto-grow-phantom-scroll branch April 4, 2024 23:45
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
… height is uncapped (MudBlazor#8235)

* Remove phantom scrollbars when auto grow is enabled and max height is uncapped

* Reference PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants