Skip to content

DialogService: Constrain Dialogs to IComponent instead of ComponentBase#8232

Merged
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:issue_3739
Feb 25, 2024
Merged

DialogService: Constrain Dialogs to IComponent instead of ComponentBase#8232
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:issue_3739

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Feb 25, 2024

Description

Revives this PR: #5431

Resolves: #3739

This was asked multiples times, this change gives more freedom for customization

How Has This Been Tested?

Via docs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro requested a review from henon February 25, 2024 00:35
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 25, 2024
@ScarletKuro ScarletKuro mentioned this pull request Feb 25, 2024
Closed
6 tasks
@codecov
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.23%. Comparing base (f620be7) to head (18eba6d).
Report is 3 commits behind head on dev.

Files Patch % Lines
src/MudBlazor/Services/DialogService.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #8232   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         394      394           
  Lines       11764    11767    +3     
  Branches     2385     2385           
=======================================
+ Hits        10380    10383    +3     
  Misses        857      857           
  Partials      527      527

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library API change Modifies the public API surface and removed bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 25, 2024
@henon henon merged commit a0aea93 into MudBlazor:dev Feb 25, 2024
@henon
Copy link
Contributor

henon commented Feb 25, 2024

@jammerware, @Drake53 FYI
Thanks to @ScarletKuro for completing the PR.

@ScarletKuro ScarletKuro deleted the issue_3739 branch February 25, 2024 11:50
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@ScarletKuro @biegehydra
DialogService: Constrain Dialogs to IComponent instead of ComponentBa…
3368cae 
…se (MudBlazor#8232)
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon Awaiting requested review from henon

Assignees

No one assigned

Labels

API change Modifies the public API surface enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change the constraint on DialogService.Show() from ComponentBase to IComponent

2 participants

@ScarletKuro @henon